-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-20447] Fix mistakes in "http custom mechanism" readme #1024
[WFLY-20447] Fix mistakes in "http custom mechanism" readme #1024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @mskacelik, thanks for this. I have a few changes to request, you should only change README-source.adoc, the README.adoc is just a flattened version of README-source.adoc that is auto updated after each PR merge.
So the other README.adoc changes you did should actually be around the following include, that is wrongly done twice:
:restoreScriptName: restore-configuration.cli
include::../shared-doc/restore-standalone-server-configuration-manual.adoc[leveloffset=+2]
The problem here is that such "included" content does not really supports multiple scripts, so now you may just remove the second include (line 238), and I will create a new JIRA to add multiple script support to that shared docs content; alternatively you can do that extra too in this PR, by improving the /shared-doc/restore-standalone-server-configuration-manual.adoc now.
@mskacelik by the way, do you have already a WildFly JIRA account? I created a JIRA for your contribution at https://issues.redhat.com/browse/WFLY-20447 , if you have an account I may assign it to you, otherwise I can help as proxy, no prob. |
@fjuma it's a bit unusual place for user requests, but perhaps you want to reply here to @mskacelik , please see his question in issue description? |
Ah, that makes sense, thank you.
Yea sure, could give it a try. :)
Yes I do, Marek Skacelik ([email protected]) |
Shouldn't the included file on line 226 be: |
186129e
to
b94b9c2
Compare
b94b9c2
to
cdbc278
Compare
@mskacelik thank you :-) |
Issue: https://issues.redhat.com/browse/WFLY-20447
While going through this quickstart I probably found some mistakes in the readme.
Also bit off topic, but how exactly does the password validation work for the custom mechanism, given that
X-PASSWORD
could be anything and response is still OK (200) (unlike theX-USERNAME
)